Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table - warn that ActionsColumn API changed #253

Closed
kmcfaul opened this issue Feb 13, 2023 · 2 comments · Fixed by #259
Closed

Table - warn that ActionsColumn API changed #253

kmcfaul opened this issue Feb 13, 2023 · 2 comments · Fixed by #259
Assignees
Milestone

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 13, 2023

Codemod for patternfly/patternfly-react#8629

ActionsColumn now utilizes Dropdown next:
direction, position, matching trigger width now controlled by popperProps
toggle should now be a MenuToggle

@gitdallas
Copy link
Contributor

While testing cost, I came across this.

  • It hasn't been added to the "warnings" so it is coming through as an error
  • The message says to use "MenuToggle" rather than "DropdownToggle", I wonder if we can be more selective and check if the user actually has anything that might need to change?

Thoughts @kmcfaul @thatblindgeye ?

@thatblindgeye
Copy link
Collaborator

It'd probably be worth updating the message so only relevant info is given. If no tables are using an actionsToggle, they probably don't need to be warned that a MenuToggle should be used over a DropdownToggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants