Enable JSS and update scripts#13
Merged
Hyperkid123 merged 6 commits intopatternfly:mainfrom Feb 7, 2023
fhlavac:main
Merged
Conversation
Contributor
fhlavac
commented
Feb 6, 2023
fhlavac
commented
- enabled JSS + removed scss
- updated scripts to use npm
- added missing eslint rules
- removed components, which are not needed for now
Hyperkid123
reviewed
Feb 7, 2023
Collaborator
Hyperkid123
left a comment
Hyperkid123
left a comment
There was a problem hiding this comment.
Looks good, but I would use the CSS variables instead of the imported tokens. You can use the CSS variables as in classic CSS. Just wrap them as strings.
| textAlign: 'left', | ||
| backgroundColor: 'white', | ||
| borderStyle: 'solid', | ||
| borderColor: backgroundDark.value, |
Collaborator
There was a problem hiding this comment.
I think you can just use the 'var(--pf-...)' strings instead of these tokens. It might be safer than importing the values.
Contributor
Author
There was a problem hiding this comment.
@Hyperkid123 thank you, pushed the update
Hyperkid123
approved these changes
Feb 7, 2023
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.3-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.