PatternFly version 5 update by dlabaj · Pull Request #28 · patternfly/react-component-groups

dlabaj · 2023-06-22T13:11:40Z

PatternFly version 5 update for react-component-groups.

Upgraded to PF v5.

wise-king-sullyman

Mostly looks good, a few comments about configs and such, and it looks like something is throwing an error when the unit tests run.

wise-king-sullyman · 2023-06-23T19:47:39Z

.cache_zqijbm

@@ -0,0 +1 @@
+[{"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx":"1","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx":"2","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts":"3","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/DefaultErrorMessage.tsx":"4","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx":"5","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts":"6","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx":"7","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts":"8","/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts":"9"},{"size":2074,"mtime":1679316214554,"results":"10","hashOfConfig":"11"},{"size":1237,"mtime":1679316214555,"results":"12","hashOfConfig":"11"},{"size":60,"mtime":1679316214555,"results":"13","hashOfConfig":"11"},{"size":404,"mtime":1675096338736,"results":"14","hashOfConfig":"11"},{"size":1860,"mtime":1685547240249,"results":"15","hashOfConfig":"11"},{"size":126,"mtime":1679316214556,"results":"16","hashOfConfig":"11"},{"size":2226,"mtime":1685547240249,"results":"17","hashOfConfig":"11"},{"size":103,"mtime":1675096338738,"results":"18","hashOfConfig":"11"},{"size":63,"mtime":1685465904320,"results":"19","hashOfConfig":"11"},{"filePath":"20","messages":"21","suppressedMessages":"22","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"sqltza",{"filePath":"23","messages":"24","suppressedMessages":"25","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"26","messages":"27","suppressedMessages":"28","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"29","messages":"30","suppressedMessages":"31","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"32","messages":"33","suppressedMessages":"34","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"35","messages":"36","suppressedMessages":"37","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"38","messages":"39","suppressedMessages":"40","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"41","messages":"42","suppressedMessages":"43","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"44","messages":"45","suppressedMessages":"46","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/DefaultErrorMessage.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx",["47"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts",[],[],{"ruleId":null,"message":"48","line":8,"column":3,"endLine":8,"endColumn":65,"severity":1,"nodeType":null},"'//eslint-disable-next-line' has no effect because you have 'noInlineConfig' setting in your config (BaseConfig)."]


I think we probably want to remove this file

wise-king-sullyman · 2023-08-25T18:30:37Z

packages/module/.cache_u2fydo

@@ -0,0 +1 @@
+[{"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPage/DetailsPage.tsx":"1","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPage/index.ts":"2","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx":"3","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/DetailsPageHeader.tsx":"4","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/index.ts":"5","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButton.tsx":"6","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButtons.test.tsx":"7","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButtons.tsx":"8","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionMenu.test.tsx":"9","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionMenu.tsx":"10","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/Breadcrumbs.test.tsx":"11","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/Breadcrumbs.tsx":"12","/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/index.ts":"13","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx":"14","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts":"15","/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/HorizontalNav.test.tsx":"16","/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/HorizontalNav.tsx":"17","/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/index.ts":"18","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx":"19","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts":"20","/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts":"21","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/Batery.test.tsx":"22","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/Battery.tsx":"23","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/CriticalBattery.tsx":"24","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/HighBattery.tsx":"25","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/LowBattery.tsx":"26","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/MediumBattery.tsx":"27","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/NullBattery.tsx":"28","/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/index.ts":"29","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.test.tsx":"30","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx":"31","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx":"32","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts":"33","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.test.tsx":"34"},{"size":771,"mtime":1689171635343,"results":"35","hashOfConfig":"36"},{"size":31,"mtime":1689171635345,"results":"37","hashOfConfig":"36"},{"size":2918,"mtime":1689171635344,"results":"38","hashOfConfig":"36"},{"size":5092,"mtime":1689692005026,"results":"39","hashOfConfig":"36"},{"size":62,"mtime":1689171635345,"results":"40","hashOfConfig":"36"},{"size":1029,"mtime":1689692005025,"results":"41","hashOfConfig":"36"},{"size":992,"mtime":1689171635349,"results":"42","hashOfConfig":"36"},{"size":851,"mtime":1689171635346,"results":"43","hashOfConfig":"36"},{"size":2860,"mtime":1689171635347,"results":"44","hashOfConfig":"36"},{"size":6037,"mtime":1689692005026,"results":"45","hashOfConfig":"36"},{"size":1303,"mtime":1689171635348,"results":"46","hashOfConfig":"36"},{"size":1097,"mtime":1689171635346,"results":"47","hashOfConfig":"36"},{"size":126,"mtime":1689171635350,"results":"48","hashOfConfig":"36"},{"size":1903,"mtime":1689691968697,"results":"49","hashOfConfig":"36"},{"size":54,"mtime":1689171635349,"results":"50","hashOfConfig":"36"},{"size":1312,"mtime":1689171635351,"results":"51","hashOfConfig":"36"},{"size":2391,"mtime":1689177126547,"results":"52","hashOfConfig":"36"},{"size":33,"mtime":1689171635350,"results":"53","hashOfConfig":"36"},{"size":2365,"mtime":1689692005026,"results":"54","hashOfConfig":"36"},{"size":103,"mtime":1675096338738,"results":"55","hashOfConfig":"36"},{"size":224,"mtime":1689691968561,"results":"56","hashOfConfig":"36"},{"size":2793,"mtime":1689691968559,"results":"57","hashOfConfig":"36"},{"size":4157,"mtime":1689691968557,"results":"58","hashOfConfig":"36"},{"size":1171,"mtime":1689691968557,"results":"59","hashOfConfig":"36"},{"size":939,"mtime":1689691968556,"results":"60","hashOfConfig":"36"},{"size":481,"mtime":1689691968558,"results":"61","hashOfConfig":"36"},{"size":725,"mtime":1689691968558,"results":"62","hashOfConfig":"36"},{"size":1159,"mtime":1689691968558,"results":"63","hashOfConfig":"36"},{"size":375,"mtime":1689691968557,"results":"64","hashOfConfig":"36"},{"size":2876,"mtime":1689692004993,"results":"65","hashOfConfig":"36"},{"size":2307,"mtime":1689692005055,"results":"66","hashOfConfig":"36"},{"size":1238,"mtime":1689171635349,"results":"67","hashOfConfig":"36"},{"size":60,"mtime":1687374070987,"results":"68","hashOfConfig":"36"},{"size":784,"mtime":1689171635347,"results":"69","hashOfConfig":"36"},{"filePath":"70","messages":"71","suppressedMessages":"72","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"12tbhz3",{"filePath":"73","messages":"74","suppressedMessages":"75","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"76","messages":"77","suppressedMessages":"78","errorCount":0,"fatalErrorCount":0,"warningCount":2,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"79","messages":"80","suppressedMessages":"81","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"82","messages":"83","suppressedMessages":"84","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"85","messages":"86","suppressedMessages":"87","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"88","messages":"89","suppressedMessages":"90","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"91","messages":"92","suppressedMessages":"93","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"94","messages":"95","suppressedMessages":"96","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"97","messages":"98","suppressedMessages":"99","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"100","messages":"101","suppressedMessages":"102","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"103","messages":"104","suppressedMessages":"105","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"106","messages":"107","suppressedMessages":"108","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"109","messages":"110","suppressedMessages":"111","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"112","messages":"113","suppressedMessages":"114","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"115","messages":"116","suppressedMessages":"117","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"118","messages":"119","suppressedMessages":"120","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"121","messages":"122","suppressedMessages":"123","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"124","messages":"125","suppressedMessages":"126","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"127","messages":"128","suppressedMessages":"129","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"130","messages":"131","suppressedMessages":"132","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"133","messages":"134","suppressedMessages":"135","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"136","messages":"137","suppressedMessages":"138","errorCount":0,"fatalErrorCount":0,"warningCount":2,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"139","messages":"140","suppressedMessages":"141","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"142","messages":"143","suppressedMessages":"144","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"145","messages":"146","suppressedMessages":"147","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"148","messages":"149","suppressedMessages":"150","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"151","messages":"152","suppressedMessages":"153","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"154","messages":"155","suppressedMessages":"156","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"157","messages":"158","suppressedMessages":"159","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"160","messages":"161","suppressedMessages":"162","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"163","messages":"164","suppressedMessages":"165","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"166","messages":"167","suppressedMessages":"168","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"169","messages":"170","suppressedMessages":"171","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPage/DetailsPage.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPage/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx",["172","173"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/DetailsPageHeader.tsx",["174"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButton.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButtons.test.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionButtons.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionMenu.test.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/ActionMenu.tsx",["175"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/Breadcrumbs.test.tsx",["176"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/Breadcrumbs.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/DetailsPageHeader/utils/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/HorizontalNav.test.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/HorizontalNav.tsx",["177"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/HorizontalNav/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/Batery.test.tsx",["178"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/Battery.tsx",["179","180"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/CriticalBattery.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/HighBattery.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/LowBattery.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/MediumBattery.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/NullBattery.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/Battery/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.test.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.test.tsx",[],[],{"ruleId":null,"message":"181","line":28,"column":11,"endLine":28,"endColumn":49,"severity":1,"nodeType":null},{"ruleId":null,"message":"181","line":36,"column":11,"endLine":36,"endColumn":49,"severity":1,"nodeType":null},{"ruleId":"182","severity":1,"message":"183","line":93,"column":17,"nodeType":"184","endLine":103,"endColumn":18},{"ruleId":null,"message":"181","line":26,"column":3,"endLine":26,"endColumn":65,"severity":1,"nodeType":null},{"ruleId":null,"message":"185","line":1,"column":1,"endLine":1,"endColumn":50,"severity":1,"nodeType":null},{"ruleId":"186","severity":1,"message":"187","line":1,"column":1,"nodeType":"188","endLine":1,"endColumn":90},{"ruleId":null,"message":"181","line":44,"column":7,"endLine":44,"endColumn":45,"severity":1,"nodeType":null},{"ruleId":null,"message":"181","line":110,"column":7,"endLine":110,"endColumn":34,"severity":1,"nodeType":null},{"ruleId":null,"message":"189","line":118,"column":8,"endLine":118,"endColumn":64,"severity":1,"nodeType":null},"'//eslint-disable-next-line' has no effect because you have 'noInlineConfig' setting in your config (BaseConfig).","@patternfly/pf-codemods/label-warn-truncated-default","The Label component is now truncated by default. There is also a new property (textMaxWidth) to customize when truncation occurs. The DOM will be a little different and may require changes in your tests.","JSXOpeningElement","'/*eslint-disable*/' has no effect because you have 'noInlineConfig' setting in your config (BaseConfig).","@patternfly/pf-codemods/tabs-warn-children-type-changed","The children of the 'Tabs' component must now be passed a 'Tab' component or a falsy value.","ImportDeclaration","'/*eslint-disable-next-line*/' has no effect because you have 'noInlineConfig' setting in your config (BaseConfig)."]


I'm guessing this cache file can go as well.

wise-king-sullyman · 2023-08-25T18:32:02Z

packages/module/package.json

+    "@patternfly/react-core": "^5.0.0-prerelease.13",
+    "@patternfly/react-icons": "^5.0.0-prerelease.7",
    "react-jss": "^10.9.2"
  },
  "peerDependencies": {
-    "react": "^16.8 || ^17 || ^18",
-    "react-dom": "^16.8 || ^17 || ^18"
+    "react": "^17 || ^18",
+    "react-dom": "^17 || ^18"
  },
  "devDependencies": {
-    "@patternfly/documentation-framework": "^1.10.12",
-    "@reach/router": "1.3.4",
-    "@patternfly/patternfly": "^4.224.2",
-    "@patternfly/patternfly-a11y": "4.3.1",
-    "@patternfly/react-code-editor": "^4.82.115",
-    "@patternfly/react-table": "^4.113.0",
-    "@redhat-cloud-services/frontend-components-utilities": "^3.2.25",
-    "@types/react": "^17.0.0",
-    "@types/react-dom": "^17.0.0",
+    "@patternfly/patternfly-a11y": "^4.3.1",
+    "@patternfly/documentation-framework": "^2.0.0-alpha.57",
+    "@patternfly/patternfly": "^5.0.0-prerelease.10",
+    "@patternfly/react-table": "^5.0.0-prerelease.13",
+    "@patternfly/react-code-editor": "^5.0.0-prerelease.13",


Do we want to still be pulling in the prerelease/alpha versions of PF?

wise-king-sullyman · 2023-08-25T18:33:08Z

packages/module/package.json

  "publishConfig": {
    "access": "public",
-    "tag": "prerelease"
+    "tag": "alpha"


Do we need to be releasing on alpha from this channel rather than just prerelease?

wise-king-sullyman · 2023-08-25T18:34:17Z

packages/module/release.config.js

@@ -1,5 +1,5 @@
 module.exports = {
-  branches: [ { name: 'main', channel: 'prerelease' } ],
+  branches: [ { name: 'main', channel: 'prerelease' }, { name: 'v5', channel: 'alpha', prerelease: 'alpha' } ],


Same question about prerelease vs alpha for this.

Also are we wanting main to be the v5 branch, or do we want a v5 branch here? In most of the other extensions we've moved to having main as v5 and a v4 branch for v4.

dlabaj · 2023-08-29T10:40:10Z

@wise-king-sullyman Updated with review comments

fhlavac · 2023-08-29T12:24:35Z

packages/module/src/NotAuthorized/NotAuthorized.test.tsx

Just curious, what is the reason for removing these tests?

fhlavac

Looks good to me! Thank you @dlabaj

github-actions · 2023-08-29T13:17:57Z

🎉 This PR is included in version 1.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

dlabaj added the do not merge label Jun 22, 2023

dlabaj requested review from Hyperkid123 and wise-king-sullyman June 22, 2023 13:11

dlabaj changed the title ~~Patternfly version 5 update~~ (WIP) PatternFly version 5 update Jun 22, 2023

dlabaj added 8 commits July 18, 2023 10:52

fix(v5): Upgraded to PF v5

a307c7d

fix(v5): Upgraded to patternfly v5

d068d8a

Removed enzyme.

80092db

Updated with test fix.

35abe3f

Updated with test fixes

bb343e4

chore(rebase): Rebased v5 with the latest from main.

ea2797e

chore(PF v5 upgrade) - Upgraded to PF v5

8c3623c

Upgraded to PF v5.

Updated with latest from main.

267e4fc

dlabaj force-pushed the v5-rebase branch from 847fc8c to 267e4fc Compare July 18, 2023 18:56

dlabaj requested a review from fhlavac July 18, 2023 18:57

Added suggeseted error boundary fix.

75935bd

dlabaj changed the title ~~(WIP) PatternFly version 5 update~~ PatternFly version 5 update Aug 25, 2023

wise-king-sullyman reviewed Aug 25, 2023

View reviewed changes

dlabaj removed the do not merge label Aug 29, 2023

Updated with review comments

1ee936f

dlabaj added 2 commits August 29, 2023 06:47

Fixed broken test

f8e7c53

Updated github actions.

c6a60e2

fhlavac reviewed Aug 29, 2023

View reviewed changes

packages/module/src/NotAuthorized/NotAuthorized.test.tsx

Copy link

Contributor

fhlavac Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is the reason for removing these tests?

Added back missing test.

687acb0

fhlavac approved these changes Aug 29, 2023

View reviewed changes

dlabaj merged commit 13274e9 into main Aug 29, 2023

github-actions bot added the released on @prerelease label Aug 29, 2023

jessiehuff mentioned this pull request Aug 29, 2023

Migrate to PatternFly V5. #16

Closed

fhlavac deleted the v5-rebase branch August 29, 2023 14:11

github-actions bot mentioned this pull request Apr 21, 2025

The automated release is failing 🚨 #692

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PatternFly version 5 update#28

PatternFly version 5 update#28
dlabaj merged 13 commits intomainfrom
v5-rebase

dlabaj commented Jun 22, 2023

Uh oh!

wise-king-sullyman left a comment

Uh oh!

wise-king-sullyman Jun 23, 2023

Uh oh!

wise-king-sullyman Aug 25, 2023

Uh oh!

wise-king-sullyman Aug 25, 2023

Uh oh!

wise-king-sullyman Aug 25, 2023

Uh oh!

wise-king-sullyman Aug 25, 2023

Uh oh!

dlabaj commented Aug 29, 2023

Uh oh!

fhlavac Aug 29, 2023

Uh oh!

fhlavac left a comment

Uh oh!

github-actions bot commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1 @@
		[{"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx":"1","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx":"2","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts":"3","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/DefaultErrorMessage.tsx":"4","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx":"5","/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts":"6","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx":"7","/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts":"8","/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts":"9"},{"size":2074,"mtime":1679316214554,"results":"10","hashOfConfig":"11"},{"size":1237,"mtime":1679316214555,"results":"12","hashOfConfig":"11"},{"size":60,"mtime":1679316214555,"results":"13","hashOfConfig":"11"},{"size":404,"mtime":1675096338736,"results":"14","hashOfConfig":"11"},{"size":1860,"mtime":1685547240249,"results":"15","hashOfConfig":"11"},{"size":126,"mtime":1679316214556,"results":"16","hashOfConfig":"11"},{"size":2226,"mtime":1685547240249,"results":"17","hashOfConfig":"11"},{"size":103,"mtime":1675096338738,"results":"18","hashOfConfig":"11"},{"size":63,"mtime":1685465904320,"results":"19","hashOfConfig":"11"},{"filePath":"20","messages":"21","suppressedMessages":"22","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"sqltza",{"filePath":"23","messages":"24","suppressedMessages":"25","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"26","messages":"27","suppressedMessages":"28","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"29","messages":"30","suppressedMessages":"31","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"32","messages":"33","suppressedMessages":"34","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"35","messages":"36","suppressedMessages":"37","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"38","messages":"39","suppressedMessages":"40","errorCount":0,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"41","messages":"42","suppressedMessages":"43","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"44","messages":"45","suppressedMessages":"46","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorBoundary.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/ErrorStack.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorBoundary/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/DefaultErrorMessage.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/ErrorState.tsx",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/ErrorState/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/NotAuthorized.tsx",["47"],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/NotAuthorized/index.ts",[],[],"/Users/dlabaj/repos/react-component-groups/packages/module/src/index.ts",[],[],{"ruleId":null,"message":"48","line":8,"column":3,"endLine":8,"endColumn":65,"severity":1,"nodeType":null},"'//eslint-disable-next-line' has no effect because you have 'noInlineConfig' setting in your config (BaseConfig)."] No newline at end of file

Conversation

dlabaj commented Jun 22, 2023

Uh oh!

wise-king-sullyman left a comment

Choose a reason for hiding this comment

Uh oh!

wise-king-sullyman Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

wise-king-sullyman Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

wise-king-sullyman Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

wise-king-sullyman Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

wise-king-sullyman Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

dlabaj commented Aug 29, 2023

Uh oh!

fhlavac Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

fhlavac left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants