Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): add support for custom GroupLabelComponent #221

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented Jun 14, 2024

What

Towards #204

Description

These updates add pill styling to group node labels as requested per RHOAI UX. Adds TaskPill logic and support for custom GroupLabelComponent

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@jenny-s51 jenny-s51 marked this pull request as draft June 14, 2024 15:25
@patternfly-build
Copy link

patternfly-build commented Jun 14, 2024

@jenny-s51 jenny-s51 changed the title [WIP] feat(pipelines): add support for custom GroupLabelComponent feat(pipelines): add support for custom GroupLabelComponent Jun 21, 2024
@jenny-s51 jenny-s51 marked this pull request as ready for review June 21, 2024 16:51
@jenny-s51 jenny-s51 requested a review from nicolethoen June 24, 2024 14:53
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one tiny code clean up note

packages/module/src/components/nodes/labels/NodeLabel.tsx Outdated Show resolved Hide resolved
fix(pipelines): add correct location, scaling, and anchors for expanded task group's pill labels. (#10)

fix(pipelines): add status prop to group labels

update import statement
@jenny-s51 jenny-s51 merged commit e41b72a into patternfly:main Jun 24, 2024
8 checks passed
Copy link

🎉 This PR is included in version 5.4.0-prerelease.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants