Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DefaultTaskGroup): Allow for a custom status icon in DefaultTaskGroup #242

Merged

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #240

Description

Adds the customStatusIcon property to the DefaultTaskGroup. This property is useful only for collapsed groups, or if using a GroupLabelComponent that accepts a customStatus icon, such as TaskGroupPillLabel.

Type of change

  • Feature

Screen shots / Gifs for design review

image

image

/cc @jpuzz0

@patternfly-build
Copy link

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in demo-app. Code/UI looks great and customStatusIcon is supported for warning state of DefaultTaskGroup.

@jeff-phillips-18 jeff-phillips-18 merged commit 2a1b615 into patternfly:v5 Oct 22, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the custom-task-group-status-icon branch October 22, 2024 11:18
jeff-phillips-18 added a commit to jeff-phillips-18/react-topology that referenced this pull request Oct 22, 2024
jeff-phillips-18 added a commit to jeff-phillips-18/react-topology that referenced this pull request Oct 25, 2024
@jeff-phillips-18
Copy link
Member Author

Released in v5.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants