Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Keyboard Shortcut Conflict #25

Open
spencer-shadley opened this issue Sep 28, 2020 · 1 comment
Open

Search Keyboard Shortcut Conflict #25

spencer-shadley opened this issue Sep 28, 2020 · 1 comment

Comments

@spencer-shadley
Copy link

The search (ctrl+K) keyboard shortcut conflicts with some browser defaults, such as Chrome's search google shortcut.

image

Repro:

Suggestion: Add an alt modifier to avoid the conflict. This is a frequent paradigm for browser-based keyboard shortcuts (for example, Google Docs uses ctrl+alt+num for toggling header styles to avoid conflicting with the browser shortcut for switching tabs (ctrl+num).

@gazcn007
Copy link
Member

Hey Spencer, I am using Docusaurus as a skeleton for the site, and they use DocSearch out of the box.

There is a thread of people discussing if they should use Ctrl+K as a hot key or not, I think it is good to let them know about the potential shortcut conflicts, esp. on Windows.
facebook/docusaurus#2815 (comment)

I will follow up on that thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants