Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Langchain::Assistant::Messages::*#to_hash methods and split by roles #856

Open
andreibondarev opened this issue Oct 24, 2024 · 1 comment
Labels
enhancement New feature or request thoughtbot-open-summit-2024 https://thoughtbot.com/events/open-summit

Comments

@andreibondarev
Copy link
Collaborator

Description

The current to_hash() method is lengthy and has too much logic in it. Example: https://github.com/patterns-ai-core/langchainrb/blob/main/lib/langchain/assistant/messages/openai_message.rb#L52-L80

Tasks:

@rishirajkumar97
Copy link
Contributor

Hi Andrei,
I am currently working on this in this draft PR - #867
Please do lemme know if theres a update on this issue.

Regards,
Rishi J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request thoughtbot-open-summit-2024 https://thoughtbot.com/events/open-summit
Projects
None yet
Development

No branches or pull requests

2 participants