Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning before attemping hardlink operations on extfat filesystems (which does not support them) #149

Open
michaelerule opened this issue Jan 19, 2024 · 0 comments

Comments

@michaelerule
Copy link

michaelerule commented Jan 19, 2024

rdfind 1.5.0 will happily run on an extfat filesystem with "-makehardlinks true" arguments. Hours later, it will then fail (because extfat file systems cannot have hard or soft links), providing the user with a list of "Failed to make hardlink" errors and no further hints. "Maybe this drive just can't do hardlinks" was my third guess, after "maybe there's something wrong with the mount or directory settings?" and "maybe there is some maximum number of hardlinks it can support?". More informative messages could save less-experienced users like myself hours of troubleshooting time.

Suggested changes are mostly related to text printed to the user and not the behavior of rdfind:

  • Attempt to detect file system(s)
  • Warn users before running that operation will likely fail (or if file system could not be determined), e.g. when combining "-makehardlinks true" with an extfat filesystem
  • If subsequent operations fail, print informative hints to the user rather than the generic "Failed to make hardlinks" output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant