Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements ideas. #48

Closed
janoamaral opened this issue Jan 27, 2020 · 2 comments
Closed

Some improvements ideas. #48

janoamaral opened this issue Jan 27, 2020 · 2 comments

Comments

@janoamaral
Copy link

janoamaral commented Jan 27, 2020

I've working on a similar implementation. Here is a couple of ideas.

  • Used the a tag <a href="https://youtu.be/3vBwRfQbXkg" class="ytlight">HOW TO FUNK IN TWO MINUTES</a>. If the user has JavaScript disabled, it can go to the video anyway.
  • Lazy load the thumbnail.
  • The quality of the thumbnail to load is decided with NetworkInformation.effectiveType.

POC

Test page lite-youtube-embed
Test page ytlight

@simevidas
Copy link

Isn’t adding an <a> element the responsibility of the website that uses the component, not the component itself?

@paulirish
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants