Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fsevents? #313

Closed
caspervonb opened this issue Jul 14, 2015 · 2 comments
Closed

Remove fsevents? #313

caspervonb opened this issue Jul 14, 2015 · 2 comments

Comments

@caspervonb
Copy link

With 0.12 supporting fsevents directly, maybe removing fsevents from chokidar in the next major should be discussed?

@paulmillr
Copy link
Owner

Unfortunately this is simply not the case. Node's native file watcher has always been extremely awful. Nothing has changed since 0.10 as far as I know. Same amount of bugs, lack of low-level file watching APIs.

@es128
Copy link
Contributor

es128 commented Jul 14, 2015

@caspervonb while 0.12 utilizes the fsevents api, it does not provide the same access to it that chokidar needs to provide stable events. Feel free to disable/remove fsevents from a particular installation and take note of the problems that occur with wrong, missed, or duplicate events.

Plus, even if node had solved its problems, we would want to keep supporting 0.10 for a while to come.

Using fsevents brings some headaches, and believe me I'd love to drop it. But dropping it would lead to an even greater amount of issues.

What we may pursue for the next major is adding an interface for watchman. See facebook/react-native#628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants