Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong usage of /* @__PURE__ */ annotation #31

Closed
martines3000 opened this issue Mar 25, 2024 · 3 comments · May be fixed by Graysonbarton/p256-verifier#4
Closed

Wrong usage of /* @__PURE__ */ annotation #31

martines3000 opened this issue Mar 25, 2024 · 3 comments · May be fixed by Graysonbarton/p256-verifier#4

Comments

@martines3000
Copy link

Hi.

I am not sure if this a bug, but I still want to mention it in case it is.

Rollup throws this warning:
image

For this part of the code:

scure-base/index.ts

Line 412 in 7134809

export const createBase58check = /* @__PURE__ */ (

It probably should be /* @__NO_SIDE_EFFECTS__ */ instead, right ?

Thank you.
@martines3000 martines3000 changed the title Wrong usage of Wrong usage of /* @__PURE__ */ annotation Mar 25, 2024
@paulmillr
Copy link
Owner

yes

@Kolezhniuk Kolezhniuk mentioned this issue Apr 18, 2024
Closed
3 tasks
@rasgo-cc
Copy link

@paulmillr any chance we could get this into 1.1.7 soon? :)

@paulmillr
Copy link
Owner

it would be great if we'd get #34 into 1.1.7 in, but we'll need tests for that. Any chance you could add them? @rasgo-cc

@Graysonbarton Graysonbarton mentioned this issue Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade @scure/base from 1.1.3 to 1.1.7 Graysonbarton/p256-verifier
3 participants
@paulmillr @rasgo-cc @martines3000