Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract snackbar messages #7

Open
paulsmithkc opened this issue Feb 28, 2022 · 0 comments
Open

Extract snackbar messages #7

paulsmithkc opened this issue Feb 28, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@paulsmithkc
Copy link
Owner

paulsmithkc commented Feb 28, 2022

In MovieListViewModel, several snackbar messages are hard-coded and need to be extracted as string resources.

Recommend changing the type of snackbarMessage to MutableLiveData<int>, so that the resource id is used instead of the string.

@paulsmithkc paulsmithkc added the bug Something isn't working label Feb 28, 2022
@paulsmithkc paulsmithkc changed the title Extract user-visible messages Extract snackbar messages Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant