We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In MovieListViewModel, several snackbar messages are hard-coded and need to be extracted as string resources.
MovieListViewModel
Recommend changing the type of snackbarMessage to MutableLiveData<int>, so that the resource id is used instead of the string.
snackbarMessage
MutableLiveData<int>
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 70 in 703d922
Line 99 in 703d922
Line 161 in 703d922
Line 164 in 703d922
Line 177 in 703d922
Line 180 in 703d922
Line 249 in 703d922
Line 278 in 703d922
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In
MovieListViewModel
, several snackbar messages are hard-coded and need to be extracted as string resources.Recommend changing the type of
snackbarMessage
toMutableLiveData<int>
, so that the resource id is used instead of the string.FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 70 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 99 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 161 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 164 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 177 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 180 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 249 in 703d922
FirebaseMovieList2022/MovieList/app/src/main/java/edu/ranken/prsmith/movielist2022/ui/MovieListViewModel.java
Line 278 in 703d922
The text was updated successfully, but these errors were encountered: