-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i128/u128 based implementation #135
Comments
This is definitely something I've been watching and something I'd like to implement. Of the two, I wanted to really see how I'm going to keep this open as I do want to iterate on this feature. |
This is still on the roadmap however due to significant restructuring will be a V2 feature instead. First stage is to stabalize towards 1.0. |
I've started some experimentation of this in the |
For those that are following this issue; I'm interested if anyone has found performance improvements on their machine? In my investigations, I also think there are perhaps three motivations here based on the comments:
I've been focusing on number 3 with this (unsuccessfully so far on my hardware), however I suspect others may be looking for either 1 (similar to the C implementation) or perhaps number 2. I'd be interested in any input here to see what people are thinking about. |
@xilec I wish to refer to your i128 based implementation,thanks a lot ,Can you share a github gist link,thanks a lot ❗️ |
It might be worth investigating using |
It sounds like this has been tried and probably isn't of use right now. Given the lower performance and the other reasons being a change in scale which I think would likely happen under possible generics work in future. Closing this for now. |
My small experiments shows that implementation
Decimal
on top of typesi128
/u128
should be simpler and more performant. In my rough reimplementation ofadd
method, timings of benchadd_negative_pi
drops from 133 ns/iter to 41 ns/iter. As I know,i128
/u128
types supported on all rust targets.I suppose it enough reasons to consider reimplementation or alternative implementation of
Decimal
type on top ofi128
/u128
.The text was updated successfully, but these errors were encountered: