Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci test #19

Merged
merged 20 commits into from
Dec 15, 2021
Merged

fix: ci test #19

merged 20 commits into from
Dec 15, 2021

Conversation

rachmadaniHaryono
Copy link
Contributor

@rachmadaniHaryono rachmadaniHaryono commented Dec 10, 2021

based on this stackoverflow answer 1 which point to this issue 2

earlier version of black can be used but imo it is better to use latest version

e: due to black upgrade, python version requirement have to be changed

now there is another error with mkdoc yaml config

e2: error on mkdocs yaml config can't be solved on windows on python version 3.6 and 3.7. see 3

e3: change on mkdocs config is based on example here 4

Footnotes

  1. https://stackoverflow.com/a/69913764/1766261

  2. https://github.com/python/typed_ast/issues/169#issuecomment-964360487

  3. https://github.com/copier-org/copier/pull/224#issuecomment-668723977

  4. https://www.mkdocs.org/user-guide/configuration/#markdown_extensions

@rachmadaniHaryono rachmadaniHaryono marked this pull request as draft December 10, 2021 12:14
@rachmadaniHaryono rachmadaniHaryono marked this pull request as ready for review December 10, 2021 13:58
project/mkdocs.yml.jinja Outdated Show resolved Hide resolved
@rachmadaniHaryono
Copy link
Contributor Author

note that python3.6 will get security update until this month

https://www.python.org/dev/peps/pep-0494/#id16

project/mkdocs.yml.jinja Outdated Show resolved Hide resolved
pawamoy and others added 2 commits December 15, 2021 19:13
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good to go! Thank you very much!

@pawamoy pawamoy merged commit 55c277d into pawamoy:master Dec 15, 2021
@rachmadaniHaryono rachmadaniHaryono deleted the bugfix/ci-test branch December 15, 2021 23:06
@rachmadaniHaryono
Copy link
Contributor Author

Not sure if True is accepted. By convention we use true and false in YAML (or yes, no, on, off)

actually there is yaml formatter hook for pre commit

https://github.com/macisamuele/language-formatters-pre-commit-hooks

https://github.com/jumanjihouse/pre-commit-hook-yamlfmt

one of those could be used to format yaml. of course some yaml file like copier-answers.yml should be excluded

this could also apply to toml files

@pawamoy
Copy link
Owner

pawamoy commented Dec 16, 2021

You can open a PR if you want. Let see what the community thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants