Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commits for building python in next release. #5187

Open
Dialga opened this issue Dec 29, 2024 · 2 comments
Open

Add commits for building python in next release. #5187

Dialga opened this issue Dec 29, 2024 · 2 comments
Labels
enhancement New feature or request non-functional Does not bring any new function, but still has to be done. It may be code refactoring, cleanup, etc.
Milestone

Comments

@Dialga
Copy link

Dialga commented Dec 29, 2024

b083e3e
fb82011

Please add these two commits to the next release to simplify building the python plugin.

@pawelsalawa
Copy link
Owner

First commit - ok.

Second commit is not a complete solution. There were few issues with it and there were subsequent improvements to it, but I'm not sure they could be integrated simply.

@pawelsalawa pawelsalawa added this to the 3.4.14 milestone Dec 29, 2024
@pawelsalawa pawelsalawa added enhancement New feature or request non-functional Does not bring any new function, but still has to be done. It may be code refactoring, cleanup, etc. labels Dec 29, 2024
@Dialga
Copy link
Author

Dialga commented Dec 30, 2024

Ok, but from the second commit these lines are enough for now:
fb82011#diff-63b7f021bfcb592c7bc462e3e43071edf474038a6a0b69ce51c1c7451b96899bL7-L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non-functional Does not bring any new function, but still has to be done. It may be code refactoring, cleanup, etc.
Projects
None yet
Development

No branches or pull requests

2 participants