Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship a Cargo-minimal.lock and Cargo-recent.lock instead of listing required pinned deps #337

Closed
DanGould opened this issue Aug 11, 2024 · 0 comments · Fixed by #357
Closed

Ship a Cargo-minimal.lock and Cargo-recent.lock instead of listing required pinned deps #337

DanGould opened this issue Aug 11, 2024 · 0 comments · Fixed by #357
Labels
enhancement New feature or request

Comments

@DanGould
Copy link
Contributor

A lock file is far more descriptive than our pins, and doesn't need to be remembered to be updated in multiple places if the tests build directly from them. See how rust-bitcoin #1764 handles this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Cargo-{minimal,recent}.lock to test deps DanGould/rust-payjoin
1 participant
@DanGould