Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent recipient from introducing mixed input script OR edit spec #39

Open
DanGould opened this issue Mar 1, 2023 · 1 comment
Open

Prevent recipient from introducing mixed input script OR edit spec #39

DanGould opened this issue Mar 1, 2023 · 1 comment
Labels
api bug Something isn't working receive receiving payjoin
Milestone
Payjoin V2 beta

Comments

@DanGould
Copy link
Contributor

DanGould commented Mar 1, 2023 •
edited
Loading

Enforce this rule on methods that mutate PayjoinProposal. Right now only senders check. I think this basic function is necessary to exit alpha for beta.

edit: would be a lot better to fix the spec in the first place bitcoin/bips#1244
@DanGould DanGould changed the title Prevent recipient from introducing mixed script / sequence Prevent recipient from introducing mixed script Mar 2, 2023
@DanGould
Copy link
Contributor Author

DanGould commented Mar 7, 2023

try_preserving_privacy also accepts any outpoints regardless of their script type. Perhaps that should filter on script as well.

@DanGould DanGould added the bug Something isn't working label Apr 10, 2023
@DanGould DanGould changed the title Prevent recipient from introducing mixed script Prevent recipient from introducing mixed input script Apr 15, 2023
@DanGould DanGould added the receive receiving payjoin label May 27, 2023
@DanGould DanGould added the api label Jul 10, 2023
@DanGould DanGould changed the title Prevent recipient from introducing mixed input script Prevent recipient from introducing mixed input script OR edit spec Jul 31, 2023
@DanGould DanGould added this to the 0.10.0 - Initial Production milestone Jul 31, 2023
@DanGould DanGould modified the milestones: payjoin-1.0, Payjoin V2 beta Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug Something isn't working receive receiving payjoin
Projects
Payjoin Roadmap 📝
Status: In Progress
Milestone
Payjoin V2 beta
Development

No branches or pull requests
1 participant
@DanGould