Skip to content

Commit 23e2f7b

Browse files
authored
templates: change names of data variables to improve clarity between data and elements (#9912)
Renames `header` to `headerData` and other props to `data` so that it's clearer for people learning Nextjs or React.
1 parent 4c57df6 commit 23e2f7b

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

templates/website/src/Footer/Component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ import { CMSLink } from '@/components/Link'
99
import { Logo } from '@/components/Logo/Logo'
1010

1111
export async function Footer() {
12-
const footer: Footer = await getCachedGlobal('footer', 1)()
12+
const footerData: Footer = await getCachedGlobal('footer', 1)()
1313

14-
const navItems = footer?.navItems || []
14+
const navItems = footerData?.navItems || []
1515

1616
return (
1717
<footer className="border-t border-border bg-black dark:bg-card text-white">

templates/website/src/Header/Component.client.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import { Logo } from '@/components/Logo/Logo'
1010
import { HeaderNav } from './Nav'
1111

1212
interface HeaderClientProps {
13-
header: Header
13+
data: Header
1414
}
1515

16-
export const HeaderClient: React.FC<HeaderClientProps> = ({ header }) => {
16+
export const HeaderClient: React.FC<HeaderClientProps> = ({ data }) => {
1717
/* Storing the value in a useState to avoid hydration errors */
1818
const [theme, setTheme] = useState<string | null>(null)
1919
const { headerTheme, setHeaderTheme } = useHeaderTheme()
@@ -35,7 +35,7 @@ export const HeaderClient: React.FC<HeaderClientProps> = ({ header }) => {
3535
<Link href="/">
3636
<Logo loading="eager" priority="high" className="invert dark:invert-0" />
3737
</Link>
38-
<HeaderNav header={header} />
38+
<HeaderNav data={data} />
3939
</div>
4040
</header>
4141
)

templates/website/src/Header/Component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import React from 'react'
55
import type { Header } from '@/payload-types'
66

77
export async function Header() {
8-
const header: Header = await getCachedGlobal('header', 1)()
8+
const headerData: Header = await getCachedGlobal('header', 1)()
99

10-
return <HeaderClient header={header} />
10+
return <HeaderClient data={headerData} />
1111
}

templates/website/src/Header/Nav/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import { CMSLink } from '@/components/Link'
88
import Link from 'next/link'
99
import { SearchIcon } from 'lucide-react'
1010

11-
export const HeaderNav: React.FC<{ header: HeaderType }> = ({ header }) => {
12-
const navItems = header?.navItems || []
11+
export const HeaderNav: React.FC<{ data: HeaderType }> = ({ data }) => {
12+
const navItems = data?.navItems || []
1313

1414
return (
1515
<nav className="flex gap-3 items-center">

templates/with-vercel-website/src/Footer/Component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ import { CMSLink } from '@/components/Link'
99
import { Logo } from '@/components/Logo/Logo'
1010

1111
export async function Footer() {
12-
const footer: Footer = await getCachedGlobal('footer', 1)()
12+
const footerData: Footer = await getCachedGlobal('footer', 1)()
1313

14-
const navItems = footer?.navItems || []
14+
const navItems = footerData?.navItems || []
1515

1616
return (
1717
<footer className="border-t border-border bg-black dark:bg-card text-white">

templates/with-vercel-website/src/Header/Component.client.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import { Logo } from '@/components/Logo/Logo'
1010
import { HeaderNav } from './Nav'
1111

1212
interface HeaderClientProps {
13-
header: Header
13+
data: Header
1414
}
1515

16-
export const HeaderClient: React.FC<HeaderClientProps> = ({ header }) => {
16+
export const HeaderClient: React.FC<HeaderClientProps> = ({ data }) => {
1717
/* Storing the value in a useState to avoid hydration errors */
1818
const [theme, setTheme] = useState<string | null>(null)
1919
const { headerTheme, setHeaderTheme } = useHeaderTheme()
@@ -35,7 +35,7 @@ export const HeaderClient: React.FC<HeaderClientProps> = ({ header }) => {
3535
<Link href="/">
3636
<Logo loading="eager" priority="high" className="invert dark:invert-0" />
3737
</Link>
38-
<HeaderNav header={header} />
38+
<HeaderNav data={data} />
3939
</div>
4040
</header>
4141
)

templates/with-vercel-website/src/Header/Component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import React from 'react'
55
import type { Header } from '@/payload-types'
66

77
export async function Header() {
8-
const header: Header = await getCachedGlobal('header', 1)()
8+
const headerData: Header = await getCachedGlobal('header', 1)()
99

10-
return <HeaderClient header={header} />
10+
return <HeaderClient data={headerData} />
1111
}

templates/with-vercel-website/src/Header/Nav/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import { CMSLink } from '@/components/Link'
88
import Link from 'next/link'
99
import { SearchIcon } from 'lucide-react'
1010

11-
export const HeaderNav: React.FC<{ header: HeaderType }> = ({ header }) => {
12-
const navItems = header?.navItems || []
11+
export const HeaderNav: React.FC<{ data: HeaderType }> = ({ data }) => {
12+
const navItems = data?.navItems || []
1313

1414
return (
1515
<nav className="flex gap-3 items-center">

0 commit comments

Comments
 (0)