fix(richtext-lexical): newlines in mdx props were stripped, even thou…

…gh objects inside props may expect there to be newlines (#10215)
payloadcms · Dec 28, 2024 · 67db04c · 67db04c
1 parent da518f5
commit 67db04c
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/...ages/richtext-lexical/src/features/blocks/server/linesFromMatchToContentAndPropsString.ts b/...ages/richtext-lexical/src/features/blocks/server/linesFromMatchToContentAndPropsString.ts
@@ -159,9 +159,6 @@ export function linesFromStartToContentAndPropsString({
     }
   }
 
-  // Replace all \n with spaces
-  propsString = propsString.replace(/\n/g, ' ').trim()
-
   const afterEndLine = linesCopy[endLineIndex].trim().slice(endlineLastCharIndex)
 
   return {

diff --git a/test/lexical-mdx/int.spec.ts b/test/lexical-mdx/int.spec.ts
@@ -1401,6 +1401,27 @@ Some line [Start of link
         },
       },
     },
+    {
+      input: `
+<PackageInstallOptions
+  update
+  packageId="Line"
+  someObject={{test: \`Line 1
+
+Line 2\`}}
+  ignored>
+</PackageInstallOptions>
+`,
+      inputAfterConvertFromEditorJSON: `<PackageInstallOptions packageId="Line" update someObject={{"test":"Line 1\\n\\nLine 2"}}/>`,
+      blockNode: {
+        fields: {
+          blockType: 'PackageInstallOptions',
+          packageId: 'Line',
+          someObject: { test: 'Line 1\n\nLine 2' },
+          update: true,
+        },
+      },
+    },
   ]
 
   const INPUT_AND_OUTPUT: Tests = INPUT_AND_OUTPUTBase //.filter((test) => test.debugFlag)

diff --git a/test/lexical-mdx/mdx/jsxBlocks/packageInstallOptions.ts b/test/lexical-mdx/mdx/jsxBlocks/packageInstallOptions.ts
@@ -10,6 +10,7 @@ export const PackageInstallOptions: Block = {
         someNestedObject: props?.someNestedObject,
         uniqueId: props?.uniqueId,
         update: props?.update,
+        someObject: props?.someObject,
       }
     },
     export: ({ fields, lexicalToMarkdown }) => {
@@ -20,19 +21,24 @@ export const PackageInstallOptions: Block = {
           someNestedObject: fields?.someNestedObject,
           uniqueId: fields?.uniqueId,
           update: fields?.update,
+          someObject: fields?.someObject,
         },
       }
     },
   },
   fields: [
     {
       name: 'packageId',
-      type: 'text',
+      type: 'textarea',
     },
     {
       name: 'global',
       type: 'checkbox',
     },
+    {
+      name: 'someObject',
+      type: 'json',
+    },
     {
       name: 'update',
       type: 'checkbox',