Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): does not render row labels until form state returns #10002

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Dec 16, 2024

Extension of #9933. Custom components are returned by form state, meaning that if we don't wait for form state to return before rendering row labels, the default row label component will render in briefly before being swapped by a custom component (if applicable). Using the new isLoading prop on array and block rows, we can conditionally render them just as we currently do for the row fields themselves.

@jacobsfletch jacobsfletch enabled auto-merge (squash) December 16, 2024 19:52
@jacobsfletch jacobsfletch enabled auto-merge (squash) December 16, 2024 21:40
@jacobsfletch jacobsfletch merged commit ed44ec0 into main Dec 16, 2024
65 checks passed
@jacobsfletch jacobsfletch deleted the fix/custom-row-label-blink branch December 16, 2024 21:44
Copy link
Contributor

🚀 This is included in version v3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant