fix(templates): prevent image priority and lazy loading incompatibility #10023
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/with-vercel-website/src/components/Media/ImageMedia/index.tsx
Outdated
Show resolved
Hide resolved
hkn-wt
force-pushed
the
fix/media-loading
branch
from
14fae65 to
3c000a1
Compare
jacobsfletch
approved these changes
Dec 17, 2024
jacobsfletch
changed the title
|
🚀 This is included in version v3.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue in the hero banner of website templates where priority props was passed to
Mediacomponent but was incompatible with NextImageloading="lazy"causing errorWhy?
To prevent error when displaying hero banners
How?
By adding a ternary condition of loading props passed to NextImage checking if
priorityprop is passed