Lexical / Paragraph menu fails in modal view

[patricsgamma]

Link to reproduction

https://github.com/patricsgamma/payload/tree/test/modal_slash

Describe the Bug

At the start of a new Paragraph within a lexical richtext field, when entering a slash "/" a menu for paragraph options appears.

✔️ This works well within a normal create or edit page
❌ It does not work when the lexical editor is embedded within a modal view. The slash "/" is just typed as such but not triggering the menu.

✔️ Video of working menu in create view

Creating a ConversationText within its own collection create view works.

working_menu.mov

❌ Video of failing modal view:

Creating a ConversationText within its parent Conversation fails.

failing_menu.mov

To Reproduce

Payload Version

"payload": "^2.3.1"

Adapters and Plugins

"@payloadcms/bundler-webpack": "^1.0.5",     
"@payloadcms/db-mongodb": "^1.1.0",     
"@payloadcms/plugin-cloud-storage": "^1.1.1",     
"@payloadcms/plugin-sentry": "^0.0.6",     
"@payloadcms/richtext-lexical": "^0.3.1"

[AlessioGr]

Hey @patricsgamma , I cannot reproduce it - even for very deeply nested drawers:

Screenshot.2023-12-07.at.14.33.02.mp4

When used inside a Blocks field, like you did:

Screenshot.2023-12-07.at.14.35.56.mp4

Could you attach a reproduction, following this reproduction guide?

[patricsgamma]

Reproduction added

[AlessioGr]

Screenshot.2023-12-20.at.20.57.18.mp4

The issue seems to be due to the condition in your navigation group field. The condition is running infinitely, which'd probably cause a buunch of issues.

You need to make sure you're returning a boolean, e.g. changing return props?.navigation to return !!props?.navigation already fixes this issue.

That being said, it seems weird that simply not returning a boolean causes this issue - I'll dig into that

[AlessioGr]

Closing this in favor of #4577 which describes the core issue. Will investigate this there

[github-actions]

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.