[plugin-search] afterDelete hook fails to delete stale search entries

[wkentdag]

Link to reproduction

https://github.com/wkentdag/payload-search-delete-bug

Describe the Bug

When you delete an item from a search-enabled collection, the stale search results are not deleted. This request in the afterDelete hook returns 0 results when there should be 1.

I was able to fix to fix the issue by copying the existing afterDelete hook into my collections and removing the req option from the aforementioned query [ref]. It looks like that line was introduced recently in #5068 to support transactions.

search-delete-bug-compressed.mov

To Reproduce

1. Clone my example repo and run it
2. create a new Page, note its search result entry, then delete it, note the stale search result entry
3. do the same thing for Pages with custom hooks, note that it works

Payload Version

2.12.1

Adapters and Plugins

bundler-webpack, db-postgres, plugin-search

[paulpopus]

Looks like this is fixed in v3

[paulpopus]

Never mind it's isolated to postgres, I will keep this closed as it's a postgres problem specifically and we'll track progress in the other issue

[github-actions]

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.