Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

[3.0 Beta 11] payload-lexical bugs #135

Closed
jloncar opened this issue Apr 22, 2024 · 4 comments
Closed

[3.0 Beta 11] payload-lexical bugs #135

jloncar opened this issue Apr 22, 2024 · 4 comments
Assignees

Comments

@jloncar
Copy link

jloncar commented Apr 22, 2024

Link to reproduction

No response

Describe the Bug

This report is about 3 bugs occuring in beta 11 payload-lexical plugin.

HorizontalRuleFeature export is missing
When starting lexical without feature list, Horizontal Rule is present.
However, this feature is not exported and cannot be added in configuration list.
Following error occurs: Module '"@payloadcms/richtext-lexical"' has no exported member 'HorizontalRuleFeature'

Fix: Should be very simple, appropriate export just needs to be added.

enabledHeadingSizes is not applied
In Heading feature

Link modal is broken
This commit seems to introduced breaking change - link feature is no longer working, modal appears to be empty and POST request to form state is erroring out with message: Could not find field schema for given path
In request payload, pages.content.feature.link.fields schema is requested (where pages is collection).

Another person reported first two issues here

To Reproduce

In Beta 11, create new collection pages with richText field.
Try overriding lexicalEditor configuration by:

  1. Passing HorizontalRuleFeature (can't import because export is missing)
  2. Pass HeadingFeature({ enabledHeadingSizes: ['h2', 'h3', 'h4', 'h5'] }) and confirm in editor that h1 and h6 are still present.
  3. With default configuration or with LinkFeature({ enabledCollections: ['page'] }), confirm modal is broken and request to get form state is erroring out.

Payload Version

beta 11

Adapters and Plugins

lexical

@jloncar
Copy link
Author

jloncar commented Apr 22, 2024

@AlessioGr FYI, I've reverted to beta 10 and link feature is working correctly now.

@jloncar jloncar changed the title payload-lexical bugs in beta 11 [3.0 Beta 11] payload-lexical bugs Apr 22, 2024
@jmikrut jmikrut transferred this issue from payloadcms/payload Apr 22, 2024
@AlessioGr
Copy link
Member

Fixed all those issues in payloadcms/payload#5893 !

Will be available in the upcoming beta.15 (not released yet)

@jloncar
Copy link
Author

jloncar commented Apr 24, 2024

Fantastic work @AlessioGr , thanks a lot!

@adesugbaa
Copy link

Thanks a lot. Will look forward and test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants