fix(ui): avoid calling getTableState from join field on create
#9256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1tsuu
changed the title
RelationshipTable on createRelationshipTable's table state on create
r1tsuu
changed the title
RelationshipTable's table state on creategetTableState from join field on create
DanRibbens
approved these changes
Nov 17, 2024
|
🚀 This is included in version v3.0.0-beta.134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the issue when visiting the create view with the Join Field and using postgres adapter
This happens because we don't have an ID yet and we send to the database:
WHERE id = NaNHow?
Avoids calling
getTableStateinside ofRelationshipTableif there's no ID yet, as it will always lead to the same empty result. While we could avoid error directly in the database adapter, I don't think we should do that render requestFixes #9193