-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getPayload
generate import map only in Next.js
#9371
Conversation
03cffa2
to
925cb03
Compare
Hey @r1tsuu, thanks again for this PR, is there anything blocking this PR being merged ? I also noticed and reported on Discord that when we load Payload outside of Next.js, the email configuration is trying to load, generating errors related to Nodemailer like so, I guess it's not exactly normal when we just want to use the Local API, what do you think ? |
I don't think, but need some eyes on it. Do you have this specific error that PR fixes? |
That's another one I'm getting on either |
That would be nice! |
925cb03
to
e39235f
Compare
getPayload
generate import map only in Next.js, move ws
dependency to @payloadcms/next
getPayload
generate import map only in Next.js
🚀 This is included in version v3.5.0 |
After the change with removing
getPayloadHMR
, we do generate import map even outside of Next.js, which leads to errors when using in a project without it: