Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(richtext-lexical): ensure hooks from sub-fields receive document data and doc props, and not node data and doc props #9406

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

AlessioGr
Copy link
Member

This also adds a new previousNode prop to afterChange node hooks, and makes sure that sub-fields receive the correct previousSiblingDoc.

…data and doc props, and not node data and doc props
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test coverage for this?

Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this to prioritze getting fixes out, but I'd really like to improve our test coverage as we can.

@DanRibbens DanRibbens merged commit 50823be into main Dec 4, 2024
52 checks passed
@DanRibbens DanRibbens deleted the fix/lexical-hooks branch December 4, 2024 13:47
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🚀 This is included in version v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants