Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate afterRead collection hook call on loginOperation #9664

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: remove duplicate afterRead collection hook call on loginOperation #9664

merged 1 commit into from
Dec 2, 2024

Conversation

1b0t
Copy link
Contributor

@1b0t 1b0t commented Dec 2, 2024 •
edited
Loading

Hi there,

i noticed that the afterRead hook is triggered twice on loginOperation.

This just removes the duplicated code.

-Tobi

@1b0t 1b0t changed the title fix(payload): remove duplicate afterRead collection hook call on loginOperation fix: remove duplicate afterRead collection hook call on loginOperation Dec 2, 2024
DanRibbens
DanRibbens approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I'm surprised we've overlooked this. Great catch!

@DanRibbens DanRibbens merged commit c5fe021 into payloadcms:main Dec 2, 2024
60 of 62 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

🚀 This is included in version v3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRibbens DanRibbens DanRibbens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1b0t @DanRibbens