fix: remove localized property from RowField and CollapsibleField
#9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I talked with James, he was also okay with merging this since we weren't sure due to the possible type error that could result in user's projects. We just need a fat warning in the description and something to go in the release notes.
We can merge it once the conflicts are resolved.
…ed-row-collapsioble-typescript
|
🚀 This is included in version v3.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
localizedproperty from typescript suggestion for row and collapsible fields.Why?
Currently, this property doesn't do anything for them. This may be changed when/if we support
namefor them, but it'll work only withname.Fixes #4720