Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): copy to locale incorrect label when locale label is defined as object #9705

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Dec 3, 2024

Fixes #9701

What?

Previously, when defining localization.locales like this:

localization: {
  defaultLocale: 'en',
  locales: [{ label: { en: 'ESLocale' }, code: 'es' },{ label: { en: 'ESLocale' }, code: 'en' }],
},

The title in "copy to locale" modal was displayed incorrectly

Copy to locale: Copying from [object Object] to [object Object]

How?

Uses the getTranslation function to handle this behavior properly

@r1tsuu r1tsuu merged commit 18f9f35 into main Dec 3, 2024
58 checks passed
@r1tsuu r1tsuu deleted the fix/copy-locale-proper-label branch December 3, 2024 19:06
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🚀 This is included in version v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy to locale: Copying from [object Object] to [object Object]
1 participant