Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): broken preview if alternative auth strategy was used, invalid error handling #9785

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Dec 6, 2024

Previously, live preview did not work with oauth, as no token is present

@AlessioGr AlessioGr changed the title fix(templates): error not logged when live preview token cannot be verified fix(templates): error not logged when live preview token cannot be verified, failing responses were never returned Dec 6, 2024
@AlessioGr AlessioGr changed the title fix(templates): error not logged when live preview token cannot be verified, failing responses were never returned fix(templates): broken live preview if alternative auth strategy was used, invalid error handling Dec 6, 2024
@AlessioGr AlessioGr disabled auto-merge December 6, 2024 07:30
@AlessioGr AlessioGr requested a review from jmikrut December 6, 2024 07:30
@jacobsfletch jacobsfletch changed the title fix(templates): broken live preview if alternative auth strategy was used, invalid error handling fix(templates): broken preview if alternative auth strategy was used, invalid error handling Dec 6, 2024
@jmikrut jmikrut merged commit d8c106c into main Dec 19, 2024
22 checks passed
@jmikrut jmikrut deleted the fix/live-preview-token-verify-error branch December 19, 2024 18:23
Copy link
Contributor

🚀 This is included in version v3.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants