fix(next): thread default ServerProps to view actions and other components that were missing #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and Icon components
jacobsfletch
approved these changes
Dec 11, 2024
jacobsfletch
changed the title
|
Thanks @jacobsfletch & @AlessioGr for the review and additions! Appreciate it! |
|
@AlessioGr is going to add include a few more components to this which were also missing server props. |
AlessioGr
approved these changes
Dec 11, 2024
|
🚀 This is included in version v3.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR threads default
serverPropsto Edit & List view action slots.Why?
To be more in-line with how the docs specify custom components should work. Custom components should recieve, at minimum, the
BasePayloadinstance andi18nobject.How?
By including props into
RenderServerComponentcall in theDefaultTemplateNotes:
DefaultTemplate. Slightly awkward due to having the actions being memoized but doable. Happy to make the necessary changes for this.