-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deduplicate and abstract SQL schema building #9987
Conversation
39c9fd8
to
1fd7da7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very exciting to me. I wanted to do this when we first built SQLite and opted to speed past it. I love that you cleaned up our tech debt here.
I have a few questions after reviewing from mobile.
2f2d72e
to
bd09358
Compare
…hema building, fix schema regression, buildDrizzleRelations build all, extract some columns to their types, jsdocs, rename isLocale to locale, refactor: db specfiic geometry default value sanitization
bd09358
to
827dc45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I'll do some extra migrations regression testing just in case and then merge |
With the website template when updated to |
🚀 This is included in version v3.8.0 |
What?
Abstracts SQL schema building, significantly reducing code duplication for SQLite / Postgres
db-sqlite lines count From:
To:
Builds abstract schema in shared drizzle package that later gets converted by SQLite/ Postgres specific implementation into drizzle schema.
This, apparently can also help here #9953. It should be very trivial to implement a MySQL adapter with this as well.