Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create include-product-owners.md #71

Merged
merged 14 commits into from
Jan 22, 2021
Merged

Conversation

NewMexicoKid
Copy link
Collaborator

This was created at the Spring Summit 2017 in Geneva, Switzerland.

This was created at the Spring Summit 2017 in Geneva, Switzerland.
@NewMexicoKid NewMexicoKid added 1 - Do 1st Review 3-validated Patterns proven in multiple cases with advanced requirements (Please see our contribution handbook) labels May 3, 2017
ErinMB added 2 commits May 9, 2017 15:10
Started revising & cleanup - not finished yet - will come back
Cleaned up / revised each line item.
@ErinMB ErinMB removed the 3-validated Patterns proven in multiple cases with advanced requirements (Please see our contribution handbook) label May 11, 2017
@maxcapraro maxcapraro added the Stale We mark issues as stale after 90 days of inactivity. This does not make any judgement about value. label Apr 21, 2020
@spier
Copy link
Member

spier commented Apr 26, 2020

@NewMexicoKid about this pattern:
Do you know if this pattern is already proven (state)?
Also would you mind adding a Patlet to it?

Maybe the most important question:
Are you able to work on this pattern, or should I reach out to somebody else, or as the last resort should we close this PR and keep the pattern only as a draft?

@spier
Copy link
Member

spier commented Aug 11, 2020

Hi @NewMexicoKid (mentioning you as you spent quite some time on this PR already).

We have reworked the maturity levels of the InnerSource patterns. The new levels make it more explicit what quality standards are expected for each level. With that we will also try to get PRs merged into master faster.

Status of this pattern:

We have currently categorized the Pattern in this PR as maturity level Level 2 - Structured.

For that level we have two requirements:

  • is validated by at least one known instance
    • we suspect that this is already true, as this pattern was previously listed in the group Pattern Drafts (proven, not yet fully reviewed)
  • complies with the patterns format
    • not sure about this, especially as the pattern format may have evolved since this PR was opened

How to get this PR merged?

  • Could you confirm if the status assessment above sounds correct to you?
  • If this pattern does not match the patterns format yet, could you adapt it accordingly?
  • With that we should be able to merge this PR to master. That will also allow other contributors to level up this pattern further in subsequent PRs/contributions in the future.

I have no time to work on this, what to do?

As this PR is open for a while, it would be completely understandable if your priorities have shifted and you don't time to work on this anymore.

In that case please just let us know in a comment below. Then we can decide what to do with this PR on our own.

Thank you for your help! 👍

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Dec 26, 2020
@spier
Copy link
Member

spier commented Jan 22, 2021

@NewMexicoKid I made a number of changes to align this pattern with the Pattern Template and to move it into our new maturity levels.

I decided to move it to Level 1 (Initial) for now.

Things missing to move it to Level 2:

  • Patlet
  • Expanded explanation of the Known Instance. Based on the current description I am not sure if that Known Instance was actually implemented or rather an idea? (See "PayPal is looking into finding a search solution" link)
  • Cross-referencing and linking it to other patterns that may have been created in the meantime.

Given that this pattern has been sitting here as a PR for a long time, my suggestion would be to merge this pattern as Level 1 (Initial). Then we can wait and see if gets confirmed and improved by others in the community.

What do you think?

@spier spier removed the Stale We mark issues as stale after 90 days of inactivity. This does not make any judgement about value. label Jan 22, 2021
Copy link
Collaborator Author

@NewMexicoKid NewMexicoKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay (I added a suggestion for a patlet).

@spier spier merged commit 9ea67cb into master Jan 22, 2021
@spier spier deleted the pattern/include-product-owners branch January 22, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants