fix(utils): Checking if parent.contains is a function before using it #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 2.0.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Rendez
pushed a commit
to Rendez/downshift
that referenced
this pull request
Sep 30, 2018
…downshift-js#492) * fix(utils): Checking if parent.contains is a function before using it Closes downshift-js#490 * chore: Adding myself as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #490.
Why:
Because when using styled-components, the parent parameter in
isOrContainsNodeis a SC wrapper that doesn't contain a.containsfunction.How:
Checking if
parent.containsis a function before using it.Checklist:
I'm not sure if that's the only necessary change, but testing locally, this was enough to avoid the problem. Let me know if anything else needs to be done or added. 👍