-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] autocomplete="nope" is ignored by browsers #527
Comments
You know, we originally had off set and recently "fixed" this bug where it was ignored. Then I think the browsers updated to start honoring it because I started seeing autocomplete on downshift inputs. So I think we need to revert the fix. Could you make a pull request to change "nope" back to "off" ? Thanks! |
Hi, |
I think it's even worse. See https://medium.com/paul-jaworski/turning-off-autocomplete-in-chrome-ee3ff8ef0908 |
Ugh, I remember doing this back in my angular-Formly days. Can't really do this in downshift, but maybe we should add an example... Anyone interested? |
For what it's worth, v2.0.19 (which included #528) seemed to fix the issue for me. |
autoComplete: "nope" worked for me but autoComplete: "off" didn't |
Sorry, you'll have to go ahead and override that yourself. |
* fix autocomplete property * update react native snapshot
I think this is resolved. |
It seems you guys have changed this back to 'off' again... From line 781 of downshift.js:
autoComplete 'off' doesn't work. Can you please change it to autoComplete '__nope' or any other random name so that it actually works? |
Sorry @StupidSexyJake, that change didn't work for me. If you want "__nope" then you can set it yourself in |
Ohhh that's so easy! Sorry, my bad. I was adding it in the wrong area like so and it wasn't changing...
Works perfectly by simply moving it to getInputProps... I'm not sure why it's not working for you though, seems to work fine for me although I've only tested on Chrome so far (Version 71.0.3578.98 for Windows). |
downshift
version: 2.0.18What happened:
The attribute autocomplete="nope", set by downshift, is ignored in Chrome 67 and Opera 54 (latest at the time of writing). However autocomplete="off" on the input would work.
Problem description:
Cant deactivate the browsers auto complete what is really annoying when using the auto suggest menu.
Suggested solution:
use autocomplete="off"
or provide possibility to override the value.UPDATE: can be overwritten by passing autoComplete: "off" to getInputProps
The text was updated successfully, but these errors were encountered: