This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
fix(innerRef): allow ref as object #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 16.3 comes with a createRef API where you can add ref as an object
|
Ah, looks like there's an issue with the snapshots. Could you run |
|
Just glad I was able to help! Snapshots are now updated. |
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 177 177
Branches 50 50
=====================================
Hits 177 177
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 16.3 comes with a createRef API where you can add ref as an object
What:
Allow innerRef to be passed as an object.
Why:
Because React 16.3 comes with a createRef API, the ref to elements is not only functions anymore, it may also be objects.
How:
I have updated prop type for the innerRef prop as well as the TypeScript interface.
Checklist:
I have updated where I can see that we set types for innerRef, but it would be great if someone took a quick look as well.
I'm happy to update if there are adjustments needed.