This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
fix(getGlamorClassName): don't attempt to merge class names that aren't from glamor #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI is messed up, but I'm going to guess that everything's fine... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Don't attempt to merge class names that aren't from glamor
Why:
So that if you pass an emotion class name to a glamorous component an error won't be thrown. this CodeSandbox shows what happens without this fix
How:
Check if a class name is on glamor's registered cache before treating it as a glamor class name
Checklist: