-
Notifications
You must be signed in to change notification settings - Fork 208
Conversation
Thank you for your pull request!
Am I right? Are there anything important I missed? |
I don't think I want to bake that into kcd-scripts just yet. So let's add a |
6fc3146
to
105911b
Compare
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 177 177
Branches 50 50
=====================================
Hits 177 177 Continue to review full report at Codecov.
|
17de279
to
37996c5
Compare
Yeah I think that's pretty much it.
Added tests and fixed build as @kentcdodds suggested. Let me know if there's anything else I should do. Thanks! |
37996c5
to
45af3b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for delay. This looks OK for me.
What:
These are working typescript types for Preact. What doesn't work is the build.
To make it work, the
preact/package.json
would need to have an entry fortypings and the typings would need to be copied to the
preact
folder. Sinceall of this seems it would need to happen in
kcd-scripts
maybe @kentcdodds hassome time to help with that?
Why:
There are currently no typescript types for preact
How:
I upgraded a medium sized preact-glamorous project.
Checklist: