Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Response class is better practice! #49

Closed
lee-garden opened this issue Jun 13, 2020 · 1 comment
Closed

Use Response class is better practice! #49

lee-garden opened this issue Jun 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@lee-garden
Copy link
Member

now :
return {
err: OneApiError,
data: data
}

after :
return response(OneApiError, responseBody)

@jhaemin jhaemin added the enhancement New feature or request label Jun 15, 2020
@jhaemin
Copy link
Member

jhaemin commented Jun 25, 2020

@jhaemin jhaemin closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants