-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency specification in setup.py #28
Comments
I think this could be fixed with an
in the setup.py. I am not maintaining the pip version myself, but would accept a |
I am not sure if this will solve it:
still gives the import error. The question is rather: I think it would be better to either put the version definition somewhere else or remove all these imports from init. Then we can import the version during install without importing the complete package (which I hope is not used during install, just the version number). |
After some tests I conclude that you should either hard code the version and other meta info into setup.py or not import everything into init.py . Becasue init will be loaded no matter which submodule of a package you import so the import error will persist. |
This is also relevant to pazz/alot#886. |
The correct key name that is picked up by
pip
insetup.py
isinstall_requires
:https://github.com/pazz/urwidtrees/blob/master/setup.py#L15
Trying to install
urwidtrees
without havingurwid
installed results in:The text was updated successfully, but these errors were encountered: