Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Improvements To PB Website And Repo #54

Closed
SkySingh04 opened this issue Aug 19, 2024 · 5 comments
Closed

Security Improvements To PB Website And Repo #54

SkySingh04 opened this issue Aug 19, 2024 · 5 comments
Labels
Backend Backend issue using Typescript Future Improvement Things that are not top priority and can be looked into in the future

Comments

@SkySingh04
Copy link
Member

SkySingh04 commented Aug 19, 2024

  • Put validation Checks in the API and the frontend code
  • Make sure the recaptcha, works properly so there will be a rate limit mechanism
  • one email address can register once only
  • implement CSRF token for all API endpoint
  • Remove those API that prints out the entire db, if it is an admin functionality then put the nesscary auth mechanism there
@SkySingh04 SkySingh04 added Backend Backend issue using Typescript Future Improvement Things that are not top priority and can be looked into in the future labels Aug 19, 2024
@SkySingh04
Copy link
Member Author

We also need to update the firebase rules to enable read/write only for authenticated users

@SkySingh04
Copy link
Member Author

so in short, you guys need to

  • remove db calls, validation from the frontend
  • auth calls is ok
  • this means your firebase config will still be public
  • learn about firebase service accounts - https://firebase.google.com/docs/admin/setup
  • configure firebase rules to only allow db calls from the service account
  • this will make sure even if someone tries to call the db using the publicly available firebase config, firebase will block it
  • use firebase functions / AWS lambda to call the db using the firebase admin SDK
  • set up some APIs to interact with firebase functions or AWS lambda

@SkySingh04
Copy link
Member Author

Progress Update :
-> Removed all Db calls from frontend in #117

@SkySingh04
Copy link
Member Author

Progress Update:
Validation checks moved to backend in #128
Recaptcha Implemented in #75
Implement CSRF token for all API endpoint : Marked as will not fix

@SkySingh04
Copy link
Member Author

Validation from frontend removed in #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend issue using Typescript Future Improvement Things that are not top priority and can be looked into in the future
Projects
None yet
Development

No branches or pull requests

1 participant