Allow Setting Ca file mode #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcfens
reviewed
Sep 12, 2017
manifests/params.pp
Outdated
| @@ -5,6 +5,8 @@ | |||
| $trusted_cert_dir = '/usr/local/share/ca-certificates' | |||
| $update_cmd = 'update-ca-certificates' | |||
| $cert_dir_group = 'staff' | |||
| $cert_dir_mode = '2665' | |||
There was a problem hiding this comment.
On an out of the box Ubuntu server, the certificate directory mode is 0555 - should this match the others?
There was a problem hiding this comment.
You're right. Debian has '2665', Ubuntu has '0555'. I'll add more condition logic to reflect this difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Setting Ca file mode per certificate. Tested with Debian 8.
(i'm only submitting the PR, original work done by tmaher)