Allow package_ensure to be "latest"

[coreone]

Treat ca_cert::package_ensure: 'latest' the same as the module would present or installed

[pcfens]

I see you like to live dangerously, but it makes sense that we support it here 😄.

Thanks for the contribution! I'll try to create a new release with this shortly.

[pcfens]

Sorry for the long delay in getting this in to a release. I just pushed this to the forge in v2.2.0. Thanks again!

[jplana]

Why should be latest treated the same as present or installed? This completely blocks the ability of the module to manage the package by ignoring the latest case.

A couple of solutions might be:

  if $install_package == true {
    if $package_ensure in ['present', 'installed'] {
      ensure_packages([$package_name])
      Package[$package_name] -> Ca_cert::Ca <| |>
    }
    else {
      package { 'ca-certificates':
        ensure => $package_ensure,
        name   => $package_name,
      }
    }
  }

or

  if $install_package == true {
    if $package_ensure in ['present', 'installed', 'latest'] {
      ensure_packages([$package_name], {'ensure' => $package_ensure})
      Package[$package_name] -> Ca_cert::Ca <| |>
    }
    else {
      package { 'ca-certificates':
        ensure => $package_ensure,
        name   => $package_name,
      }
    }
  }

Either way, the latest ensure should be passed along to the resource or setting latest has the same (unintended) effect as present.

I was tempted to create a new PR, but given that this problem has already been worked on, I was curious if I was missing something.

[coreone]

@jplana I agree. I think you're right that the intent of latest is lost here. I created a new PR (#63) to make use of $package_ensure as well as keep the package namevar consistent.