Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module doesn't work when strict vars are on #92

Closed
electrical opened this issue Feb 22, 2017 · 2 comments
Closed

Module doesn't work when strict vars are on #92

electrical opened this issue Feb 22, 2017 · 2 comments

Comments

@electrical
Copy link

Hiya. When strict variables are on the module doesn't work.
The first place that gets hit is https://github.com/pcfens/puppet-filebeat/blob/master/manifests/init.pp#L93
$::filebeat_version fact doesn't exist and with strict variables it blows up.
Evaluation Error: Unknown variable: '::filebeat_version'.

You might want to run some acceptance tests with strict vars enabled and fix some things ;-)

@pcfens
Copy link
Owner

pcfens commented Feb 23, 2017

Thanks for finding this - I thought I was testing using strict variables so I'll dive in a little bit deeper.

Aside from better testing, this should be fixed in ede4c4a. I'll push an updated release to the forge soon.

@pcfens pcfens closed this as completed Feb 23, 2017
@electrical
Copy link
Author

Thanks or fixing it so quick! Will report if i find anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants