Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MP3 #10

Open
pcwalton opened this issue Feb 20, 2015 · 12 comments
Open

Support MP3 #10

pcwalton opened this issue Feb 20, 2015 · 12 comments

Comments

@pcwalton
Copy link
Owner

We should add MP3 support via FFmpeg and AudioUnit.framework on Mac. It may also be desirable to add ID3 support.

@cuzbog
Copy link

cuzbog commented Aug 13, 2015

Is it ok if we don't use FFmpeg or AudioUnit.framework and write a decoder in Rust instead?

@pcwalton
Copy link
Owner Author

It is, but that decoder should be treated as a fallback for when no hardware decoder is available. Sadly, the only way to use HW decoders is typically the platform APIs, due to the closed proprietary nature of decoders :(

@cuzbog
Copy link

cuzbog commented Aug 13, 2015

But isn't that only for Win + Mac? For Linux we're using software decoding anyways, aren't we?

@pcwalton
Copy link
Owner Author

Yeah, I don't think desktop Linux usually uses HW decoding, so a pure Rust solution sounds just fine there. Assuming it works and is fast enough, of course :)

@cuzbog
Copy link

cuzbog commented Aug 13, 2015

It would be an interesting experiment :)

@cuzbog
Copy link

cuzbog commented Aug 15, 2015

How would we go about per-frame headers and info (ex. sampling rate)? It is common practice to assume that every frame will be like the first, but that's not correct per se.

@cuzbog
Copy link

cuzbog commented Aug 20, 2015

@pcwalton ^^

@pcwalton
Copy link
Owner Author

Usually I've been following the way mkv does these things. For example, the notion of cluster/track/etc. is taken from mkv. So I guess my answer would be "however mkv handles it".

@cuzbog
Copy link

cuzbog commented Aug 20, 2015

@pcwalton Well, it seems like mkv handles it exactly the way I put it (at least judging by this), which assumes that each frame has the same headers, but this is not correct, and it will not allow features such as variable bitrate

@ritiek
Copy link

ritiek commented Oct 2, 2017

Any update on MP3 support?

@jdm
Copy link
Contributor

jdm commented Oct 2, 2017

Nobody is working on rust-media at this point.

@lieff
Copy link

lieff commented Jan 31, 2018

Hi, here new https://crates.io/crates/minimp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants