PRC Table 96 PRC_TYPE_GRAPH_TextureDefinition

[mvrhel]

Describe the bug
The data described in the table of the spec does not match the actual content that is in the file.

While I have not been able to figure out where or how the table is wrong, it is clear to me in attempting to parse it with multiple files that something is wrong in the table description. One clear issue is that the text prior to the table discusses how blend_src_rgb, blend_dst_rgb, blend_src_alpha, blend_dst_alpha are present in this structure, but then the table only includes blend_src_rgb and blend_src_alpha. It would be good to have a full review of each element, data type, and when and if it is optional.

[t3dr0]

Here are draft changes to two tables:

Ref: 7.5.7 PRC_TYPE_GRAPH_TextureDefinition
Table 97 — PRC_TYPE_GRAPH_TextureDefinition:

1. Remove the row:
   texture_wrapping_mode | Character | (Required) texture_wrapping_mode
2. Change the row: has_transformation | Boolean | (Required) has_transformation,
   description should say: (Optional; if texture_mapping_type is) texture mapping operator. Assumes transformation type is Cartesian.
3. Change "transformation" row description from: "(Optional; if has_transformation is TRUE) If ( has_transformation != 0)" to:
   (Optional; if has_transformation is TRUE and texture_mapping_type value is texture mapping operator 3) Transformation type is Cartesian.
4. After the row "blend_src_rgb", add an additional row:
   blend_dst_rgb | integer | (Optional; if blend_src_rgb is non-zero) blend_dst_rgb
5. After the row "blend_src_alpha", add an additional row:
   blend_dst_alpha | integer | (Optional; if blend_src_alpha is non-zero) blend_dst_alpha

Table 98 — Texture mapping type
6. Add short-hand label in parentheses in each row for clarification:
0 (unknown)
1 (stored)
2 (parametric)
3 (texture_mapping_operator)

[mvrhel]

Coding up this description I can verify that it works for several files.