Bug in filter translation

[agonyz]

Bug description

In the filter translation the name is set to a boolean instead of the translation value.

It works for translations that are purely uppercase eg. KAUFEN because the value gets set again in Line 348 but does not for mixed eg. MIETE_PACHTEN.

This bug can be fixed by using the Null Coalescing Operator.

Steps to reproduce

Install the bundle, use the filter and have a translation that is not purely uppercase.

Expected behavior

The filter should output the translation from the translation files.

Screenshots

Frontend output of filter button shows "1" should be "Mieten/Pachten"

Debugging with Symfony Profiler

Environment

• PHP-Version: 7.4.30
• Contao-Version: 4.13.14
• Bundles:
  • pdir/maklermodul-bundle: 2.8.2
  • pdir/maklermodul-sync-bundle: 2.7.2

This bug can be fixed by my pull-request: #33

[seibtph]

Thanks for the PR. Version 2.8.3 is published.