Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a fixer for deprecating cross platform strategy #3259

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.27%. Comparing base (0097247) to head (65e0351).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/cli/commands/fix/fixers.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
- Coverage   85.30%   85.27%   -0.04%     
==========================================
  Files         112      112              
  Lines       11352    11368      +16     
  Branches     2473     2474       +1     
==========================================
+ Hits         9684     9694      +10     
- Misses       1140     1146       +6     
  Partials      528      528              
Flag Coverage Δ
unittests 85.07% <72.22%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit ae4d6cc into main Nov 6, 2024
22 of 24 checks passed
@frostming frostming deleted the feat/fix-cross-platform branch November 6, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant